RHCLOUD-36896 | refactor: increment errors counter when retries have been depleted #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if an error occurs when attempting to store the payload in the first attempt, the "processing errors" counter is incremented, even if that payload might be properly stored in a second attempt. This might trigger alerts that actually do not really need any attention, since the payloads might be getting updated correctly. RHCLOUD-36896
dehort
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Increment the "processed errors" counter only when all the retries have been depleted.
Why?
Right now if an error occurs when attempting to store the payload in the first attempt, the "processing errors" counter is incremented, even if that payload might be properly stored in a second attempt.
This might trigger alerts that actually do not really need any attention, since the payloads might be getting updated correctly.
Jira ticket
[RHCLOUD-36896]