Add/run create error #410
Merged
Add/run create error #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehort
requested changes
Nov 6, 2024
dehort
approved these changes
Nov 7, 2024
|
Oh! The pr check is back! Yay! \o/ |
|
I just thought of something. We need to add the |
dehort
requested changes
Nov 7, 2024
There was a problem hiding this comment.
I just thought of something. We need to add the message field to the openapi spec:
https://github.com/RedHatInsights/playbook-dispatcher/blob/master/schema/private.openapi.yaml#L246
|
/retest |
|
@dscervantes I think this is failing because the api code needs to be regenerated because we changed the openapi spec. Can you run |
|
This looks related to: golang/go#69361 |
skarekrow
force-pushed
the
add/runCreateError
branch
2 times, most recently
from
fa16ee9 to
1f733a8
Compare
skarekrow
force-pushed
the
add/runCreateError
branch
from
1f733a8 to
f7946bc
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Explain what the change is linking any relevant JIRAs or Issues.
add an error message to the response from the dispatch api call
https://issues.redhat.com/browse/RHCLOUD-35452
Why?
Consider what business or engineering goal does this PR achieves.
https://issues.redhat.com/browse/RHCLOUD-35452
How?
Describe how the change is implemented. Any noteable new libaries, APIs, or features.
Testing
Did you add any tests for the change?
Anything Else?
Any other notes about the PR that would be useful for the reviewer.
Secure Coding Practices Checklist Link
Secure Coding Checklist