Apply suggestions from code review

Co-authored-by: Meni Yakove <[email protected]>
RedHatQE · Jan 18, 2024 · 530749c · 530749c
1 parent 53bce6e
commit 530749c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/cli/objects/job.py b/cli/objects/job.py
@@ -326,11 +326,10 @@ def _find_failures(self, logs_dir: str, junit_dir: str) -> Optional[list[Failure
         # Combine lists into one list
         for failure in itertools.chain(test_failures, pod_failures):
             if failure.step not in unique_steps_with_failures:
-                unique_steps_with_failures.update([failure.step])
+                unique_steps_with_failures.add(failure.step)
                 if self.firewatch_config.failure_rules:
                     for rule in self.firewatch_config.failure_rules:
-                        if rule.matches_failure(failure) and rule.ignore:
-                            failure.ignore = True
+failure.ignore = rule.matches_failure(failure) and rule.ignore
                 failures_list.append(failure)
 
         if len(failures_list) > 0: