Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug #133 #141

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Fix bug #133 #141

merged 8 commits into from
Jan 23, 2024

Conversation

amp-rh
Copy link
Collaborator

@amp-rh amp-rh commented Jan 16, 2024

fix #133

  • add "ignore" flag to Failures
  • mark ignored failures during collection of failures in Job class
  • update unit tests

@redhat-qe-bot
Copy link
Collaborator

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported /retest check runs
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2024

Hi @amp-rh. Thanks for your PR.

I'm waiting for a CSPI-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

madunn
madunn reviewed Jan 16, 2024
View reviewed changes
tests/unittests/conftest.py Outdated Show resolved Hide resolved
myakove
myakove requested changes Jan 17, 2024
View reviewed changes
cli/objects/failure_rule.py Outdated Show resolved Hide resolved
cli/objects/failure_rule.py Outdated Show resolved Hide resolved
cli/objects/failure_rule.py Outdated Show resolved Hide resolved
cli/objects/failure_rule.py Show resolved Hide resolved
cli/objects/job.py Outdated Show resolved Hide resolved
tests/unittests/objects/failure_rule/test_firewatch_objects_failure_rule_matches_failure.py Outdated Show resolved Hide resolved
tests/unittests/objects/fixtures/test_fixtures.py Outdated Show resolved Hide resolved
tests/unittests/objects/fixtures/test_fixtures.py Outdated Show resolved Hide resolved
...ttests/objects/job/test_fail_with_test_failures_should_not_cause_failure_for_ignored_step.py Outdated Show resolved Hide resolved
...ttests/objects/job/test_fail_with_test_failures_should_not_cause_failure_for_ignored_step.py Outdated Show resolved Hide resolved
@amp-rh amp-rh force-pushed the fix-bug-133 branch 2 times, most recently from 396d9c8 to 479afa5 Compare January 18, 2024 15:01
@amp-rh amp-rh force-pushed the fix-bug-133 branch 2 times, most recently from a09caf2 to 83830e9 Compare January 19, 2024 18:48
myakove
myakove requested changes Jan 21, 2024
View reviewed changes
cli/objects/job.py Outdated Show resolved Hide resolved
calebevans
calebevans approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@calebevans calebevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@calebevans
Copy link
Collaborator

/ok-to-test

@redhat-qe-bot1
Copy link

Label ok-to-test is not a predefined one, will not be added / removed.
Available labels:

  • hold
  • verified
  • wip
  • lgtm

@calebevans
Copy link
Collaborator

pre-commit.ci run

@calebevans
Copy link
Collaborator

/verified

@calebevans calebevans merged commit f1dc2fb into RedHatQE:main Jan 23, 2024
5 checks passed
@amp-rh amp-rh deleted the fix-bug-133 branch January 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebevans calebevans calebevans approved these changes

@chetna14manku chetna14manku Awaiting requested review from chetna14manku

@smatula smatula Awaiting requested review from smatula

@liswang89 liswang89 Awaiting requested review from liswang89

@oharan2 oharan2 Awaiting requested review from oharan2

@madunn madunn Awaiting requested review from madunn

@rnetser rnetser Awaiting requested review from rnetser

@myakove myakove Awaiting requested review from myakove

Assignees
No one assigned
Labels
approved-calebevans branch-main can-be-merged ok-to-test size/XXL verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fail with test failures is being triggered with ignore rules
7 participants
@amp-rh @redhat-qe-bot @calebevans @redhat-qe-bot1 @myakove @madunn @rnetser