Skip to content

Commit

Permalink
xyyCSD2BY1: do not ignore nonconvergence
Browse files Browse the repository at this point in the history 
The xBBCSD info output was ignored leaving callers unaware of
convergence failures.
  • Loading branch information
@christoph-conrads
christoph-conrads committed Dec 1, 2023
1 parent 3200980 commit 8e7494e
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
8 changes: 4 additions & 4 deletions SRC/cuncsd2by1.f
View file
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ SUBROUTINE CUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ 1, RWORK(IB11D), RWORK(IB11E), RWORK(IB12D),
$ RWORK(IB12E), RWORK(IB21D), RWORK(IB21E),
$ RWORK(IB22D), RWORK(IB22E), RWORK(IBBCSD),
$ LRWORK-IBBCSD+1, CHILDINFO )
$ LRWORK-IBBCSD+1, INFO )

Check warning on line 573 in SRC/cuncsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/cuncsd2by1.f#L573 

Added line #L573 was not covered by tests
*
* Permute rows and columns to place zero submatrices in
* preferred positions
Expand Down Expand Up @@ -624,7 +624,7 @@ SUBROUTINE CUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ LDU2, RWORK(IB11D), RWORK(IB11E), RWORK(IB12D),
$ RWORK(IB12E), RWORK(IB21D), RWORK(IB21E),
$ RWORK(IB22D), RWORK(IB22E), RWORK(IBBCSD), LBBCSD,
$ CHILDINFO )
$ INFO )

Check warning on line 627 in SRC/cuncsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/cuncsd2by1.f#L627 

Added line #L627 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down Expand Up @@ -679,7 +679,7 @@ SUBROUTINE CUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ U1, LDU1, RWORK(IB11D), RWORK(IB11E),
$ RWORK(IB12D), RWORK(IB12E), RWORK(IB21D),
$ RWORK(IB21E), RWORK(IB22D), RWORK(IB22E),
$ RWORK(IBBCSD), LBBCSD, CHILDINFO )
$ RWORK(IBBCSD), LBBCSD, INFO )

Check warning on line 682 in SRC/cuncsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/cuncsd2by1.f#L682 

Added line #L682 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down Expand Up @@ -751,7 +751,7 @@ SUBROUTINE CUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ V1T, LDV1T, RWORK(IB11D), RWORK(IB11E),
$ RWORK(IB12D), RWORK(IB12E), RWORK(IB21D),
$ RWORK(IB21E), RWORK(IB22D), RWORK(IB22E),
$ RWORK(IBBCSD), LBBCSD, CHILDINFO )
$ RWORK(IBBCSD), LBBCSD, INFO )

Check warning on line 754 in SRC/cuncsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/cuncsd2by1.f#L754 

Added line #L754 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down
8 changes: 4 additions & 4 deletions SRC/dorcsd2by1.f
View file
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ SUBROUTINE DORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ DUM2, 1, WORK(IB11D), WORK(IB11E),
$ WORK(IB12D), WORK(IB12E), WORK(IB21D),
$ WORK(IB21E), WORK(IB22D), WORK(IB22E),
$ WORK(IBBCSD), LBBCSD, CHILDINFO )
$ WORK(IBBCSD), LBBCSD, INFO )

Check warning on line 533 in SRC/dorcsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/dorcsd2by1.f#L533 

Added line #L533 was not covered by tests
*
* Permute rows and columns to place zero submatrices in
* preferred positions
Expand Down Expand Up @@ -584,7 +584,7 @@ SUBROUTINE DORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ LDU2, WORK(IB11D), WORK(IB11E), WORK(IB12D),
$ WORK(IB12E), WORK(IB21D), WORK(IB21E),
$ WORK(IB22D), WORK(IB22E), WORK(IBBCSD), LBBCSD,
$ CHILDINFO )
$ INFO )

Check warning on line 587 in SRC/dorcsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/dorcsd2by1.f#L587 

Added line #L587 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down Expand Up @@ -639,7 +639,7 @@ SUBROUTINE DORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ LDU2, U1, LDU1, WORK(IB11D), WORK(IB11E),
$ WORK(IB12D), WORK(IB12E), WORK(IB21D),
$ WORK(IB21E), WORK(IB22D), WORK(IB22E),
$ WORK(IBBCSD), LBBCSD, CHILDINFO )
$ WORK(IBBCSD), LBBCSD, INFO )

Check warning on line 642 in SRC/dorcsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/dorcsd2by1.f#L642 

Added line #L642 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down Expand Up @@ -710,7 +710,7 @@ SUBROUTINE DORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ 1, V1T, LDV1T, WORK(IB11D), WORK(IB11E),
$ WORK(IB12D), WORK(IB12E), WORK(IB21D),
$ WORK(IB21E), WORK(IB22D), WORK(IB22E),
$ WORK(IBBCSD), LBBCSD, CHILDINFO )
$ WORK(IBBCSD), LBBCSD, INFO )

Check warning on line 713 in SRC/dorcsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/dorcsd2by1.f#L713 

Added line #L713 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down
8 changes: 4 additions & 4 deletions SRC/sorcsd2by1.f
View file
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ SUBROUTINE SORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ DUM2, 1, WORK(IB11D), WORK(IB11E), WORK(IB12D),
$ WORK(IB12E), WORK(IB21D), WORK(IB21E),
$ WORK(IB22D), WORK(IB22E), WORK(IBBCSD), LBBCSD,
$ CHILDINFO )
$ INFO )

Check warning on line 533 in SRC/sorcsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/sorcsd2by1.f#L533 

Added line #L533 was not covered by tests
*
* Permute rows and columns to place zero submatrices in
* preferred positions
Expand Down Expand Up @@ -584,7 +584,7 @@ SUBROUTINE SORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ LDU2, WORK(IB11D), WORK(IB11E), WORK(IB12D),
$ WORK(IB12E), WORK(IB21D), WORK(IB21E),
$ WORK(IB22D), WORK(IB22E), WORK(IBBCSD), LBBCSD,
$ CHILDINFO )
$ INFO )

Check warning on line 587 in SRC/sorcsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/sorcsd2by1.f#L587 

Added line #L587 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down Expand Up @@ -639,7 +639,7 @@ SUBROUTINE SORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ LDU2, U1, LDU1, WORK(IB11D), WORK(IB11E),
$ WORK(IB12D), WORK(IB12E), WORK(IB21D),
$ WORK(IB21E), WORK(IB22D), WORK(IB22E),
$ WORK(IBBCSD), LBBCSD, CHILDINFO )
$ WORK(IBBCSD), LBBCSD, INFO )

Check warning on line 642 in SRC/sorcsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/sorcsd2by1.f#L642 

Added line #L642 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down Expand Up @@ -710,7 +710,7 @@ SUBROUTINE SORCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ V1T, LDV1T, WORK(IB11D), WORK(IB11E), WORK(IB12D),
$ WORK(IB12E), WORK(IB21D), WORK(IB21E),
$ WORK(IB22D), WORK(IB22E), WORK(IBBCSD), LBBCSD,
$ CHILDINFO )
$ INFO )

Check warning on line 713 in SRC/sorcsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/sorcsd2by1.f#L713 

Added line #L713 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down
8 changes: 4 additions & 4 deletions SRC/zuncsd2by1.f
View file
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ SUBROUTINE ZUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ 1, RWORK(IB11D), RWORK(IB11E), RWORK(IB12D),
$ RWORK(IB12E), RWORK(IB21D), RWORK(IB21E),
$ RWORK(IB22D), RWORK(IB22E), RWORK(IBBCSD),
$ LRWORK-IBBCSD+1, CHILDINFO )
$ LRWORK-IBBCSD+1, INFO )

Check warning on line 570 in SRC/zuncsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/zuncsd2by1.f#L570 

Added line #L570 was not covered by tests
*
* Permute rows and columns to place zero submatrices in
* preferred positions
Expand Down Expand Up @@ -621,7 +621,7 @@ SUBROUTINE ZUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ LDU2, RWORK(IB11D), RWORK(IB11E), RWORK(IB12D),
$ RWORK(IB12E), RWORK(IB21D), RWORK(IB21E),
$ RWORK(IB22D), RWORK(IB22E), RWORK(IBBCSD), LBBCSD,
$ CHILDINFO )
$ INFO )

Check warning on line 624 in SRC/zuncsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/zuncsd2by1.f#L624 

Added line #L624 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down Expand Up @@ -676,7 +676,7 @@ SUBROUTINE ZUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ U1, LDU1, RWORK(IB11D), RWORK(IB11E),
$ RWORK(IB12D), RWORK(IB12E), RWORK(IB21D),
$ RWORK(IB21E), RWORK(IB22D), RWORK(IB22E),
$ RWORK(IBBCSD), LBBCSD, CHILDINFO )
$ RWORK(IBBCSD), LBBCSD, INFO )

Check warning on line 679 in SRC/zuncsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/zuncsd2by1.f#L679 

Added line #L679 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down Expand Up @@ -747,7 +747,7 @@ SUBROUTINE ZUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ V1T, LDV1T, RWORK(IB11D), RWORK(IB11E),
$ RWORK(IB12D), RWORK(IB12E), RWORK(IB21D),
$ RWORK(IB21E), RWORK(IB22D), RWORK(IB22E),
$ RWORK(IBBCSD), LBBCSD, CHILDINFO )
$ RWORK(IBBCSD), LBBCSD, INFO )

Check warning on line 750 in SRC/zuncsd2by1.f

View check run for this annotation

Codecov / codecov/patch

SRC/zuncsd2by1.f#L750 

Added line #L750 was not covered by tests
*
* Permute rows and columns to place identity submatrices in
* preferred positions
Expand Down

0 comments on commit 8e7494e

Please sign in to comment.