Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: resolve Chrome failing test on Linux #1222

Draft
wants to merge 6 commits into
base: v6
Choose a base branch
from
+10 −6
Draft

test: resolve Chrome failing test on Linux #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9529222
test: wait for additional frame
wattachai-lseg Oct 3, 2024
d3366d4
test: add timeout to rule out timing issue
wattachai-lseg Oct 3, 2024
53f5156
test(overlay): revert back test debugging
wattachai-lseg Dec 2, 2024
77c0ddb
test: use Chrome headless instead of headless shell
wattachai-lseg Dec 2, 2024
da47862
Merge branch 'v6' into test/fix-overlay-position-chrome-linux
wattachai-lseg Dec 2, 2024
c523370
test: use headless=new flag with Chrome
wattachai-lseg Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions karma.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,14 @@ if (!argv.watch) {
flags: ['-headless']
},
chrome: {
base: 'ChromeHeadless',
flags: ['--no-sandbox', '--disable-setuid-sandbox', '--disable-translate', '--disable-extensions']
base: 'Chrome',
flags: [
'--headless=new',
'--no-sandbox',
'--disable-setuid-sandbox',
'--disable-translate',
'--disable-extensions'
]
},
ie: {
base: 'IE',
Expand Down
6 changes: 2 additions & 4 deletions packages/elements/src/overlay/__test__/mocks/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import { elementUpdated, fixture, isIE, nextFrame } from '@refinitiv-ui/test-hel
export const openedUpdated = async (element) => {
await elementUpdated(element);

await nextFrame();
await nextFrame();
await nextFrame(2);
};
export const fireKeydownEvent = (element, key, shiftKey = false) => {
let event;
Expand Down Expand Up @@ -106,8 +105,7 @@ export const createPositionTargetFixture = async (

await elementUpdated(elements.panel);

await nextFrame();
await nextFrame();
await nextFrame(2);
}

return elements;
Expand Down
Loading