-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for avatar decorations #260
base: main
Are you sure you want to change the base?
Support for avatar decorations #260
Conversation
Looks good so far. |
Ah yes, the deserialization tests. Almost forgot. Thanks! |
/// <returns>A result which may or may not have succeeded.</returns> | ||
public static Result<Uri> GetUserAvatarDecorationUrl | ||
( | ||
IUser user, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPartialUser
might be better to use to also support those instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's IUser
to be consistent with the other methods (such as GetUserBannerUrl below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think IPartialUser
should be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that'd be better suited for its own PR to overhaul the entire CDN class. cc @Nihlus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say so aswell with its own PR then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's do that separately.
Any updates on this PR? |
discord/discord-api-docs#5723