Skip to content

Commit

Permalink
Housekeeping: FIX: make update-dependencies puts the revision into <c…
Browse files Browse the repository at this point in the history
…hangelist>

It should keep the configured "-SNAPSHOT" there.

"make update-dependencies" doesn't just update lines like "<maven-assembly-plugin.version>3.7.0</maven-assembly-plugin.version>", but it also changes the "<changelist>-SNAPSHOT</changelist>" to "<changelist>1.0.4</changelist>", presumably because the "-SNAPSHOT" looks like a version and is referenced by our "parent" artifact, and for that the latest available version is inserted.
We want the "-SNAPSHOT" to remain there in order to produce snapshots on default builds; our CI/CD-build on main explicitly disables snapshots. Therefore, exclude the "changelist" property from updates.
  • Loading branch information
inkarkat committed Mar 26, 2024
1 parent 0a33de9 commit 7a9a8e0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,7 @@
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
<configuration>
<excludeProperties>changelist</excludeProperties>
<ruleSet>
<rules>
<!-- We'll upgrade to PMD 7 once it's released. -->
Expand Down

0 comments on commit 7a9a8e0

Please sign in to comment.