Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-4170 introduce java version 21 #20

Merged
merged 4 commits into from
May 14, 2024
Merged

TASK-4170 introduce java version 21 #20

merged 4 commits into from
May 14, 2024

Conversation

Wolf2323
Copy link
Member

@Wolf2323 Wolf2323 commented May 7, 2024


  • The main commit(s) reference the Fibery ticket via a TASK-NNNN prefix in the commit message subject
  • Include a human-readable description of what the pull request is trying to accomplish
  • The CI build passes

  • New automated tests have been added
  • The changes are already covered by automated tests and have been adapted
  • These manual test cases cover this change:
  • Steps for the reviewer(s) on how they can manually QA the changes:
  • This is a minor internal change; basic CI/CD coverage is enough
  • This is an incomplete feature hidden behind feature flag:
  • This is proof-of-concept / experimental code not for production / marked @Deprecated
  • No (significant) changes to production code

  • Classes and public methods have documentation (that doesn't just repeat the technical subject in English)
  • Logging is implemented to monitor feature usage and troubleshoot problems in production
  • These ReWiki pages are affected by this change and will be adapted:

@Wolf2323 Wolf2323 requested a review from inkarkat May 7, 2024 08:25
pom.xml Show resolved Hide resolved
@Wolf2323 Wolf2323 force-pushed the TASK-4170/java21 branch 4 times, most recently from d52c1cf to 18707d1 Compare May 8, 2024 14:31
@Wolf2323 Wolf2323 force-pushed the TASK-4170/java21 branch from 18707d1 to 5d89928 Compare May 14, 2024 15:05
@Wolf2323 Wolf2323 merged commit 368d3b6 into main May 14, 2024
4 checks passed
@Wolf2323 Wolf2323 deleted the TASK-4170/java21 branch May 14, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants