Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XXX: Use updated 2.2.2 linter with editorconfig-maven-plugin 0.1.3 for the fixed .idea default exclude #21

Merged
merged 1 commit into from
May 27, 2024

Conversation

inkarkat
Copy link
Contributor

Python development is hampered by EditorConfig complaining about violations in .idea directories when they are not directly in the repo root.
This got fixed in ec4j/editorconfig-linters#25, but no editorconfig-maven-plugin has been released; only the dependencies themselves.


  • The main commit(s) reference the Fibery ticket via a TASK-NNNN prefix in the commit message subject
  • Include a human-readable description of what the pull request is trying to accomplish
  • The CI build passes

  • New automated tests have been added
  • The changes are already covered by automated tests and have been adapted
  • These manual test cases cover this change:
  • Steps for the reviewer(s) on how they can manually QA the changes:
  • This is a minor internal change; basic CI/CD coverage is enough
  • This is an incomplete feature hidden behind feature flag:
  • This is proof-of-concept / experimental code not for production / marked @Deprecated
  • No (significant) changes to production code

  • Classes and public methods have documentation (that doesn't just repeat the technical subject in English)
  • Logging is implemented to monitor feature usage and troubleshoot problems in production
  • These ReWiki pages are affected by this change and will be adapted:

…r the fixed .idea default exclude

Python development is hampered by EditorConfig complaining about violations in .idea directories when they are not directly in the repo root.
This got fixed in ec4j/editorconfig-linters#25, but no editorconfig-maven-plugin has been released; only the dependencies themselves.
@inkarkat inkarkat enabled auto-merge (rebase) May 27, 2024 06:43
@inkarkat inkarkat merged commit 9605ff6 into main May 27, 2024
4 checks passed
@inkarkat inkarkat deleted the xxx/editorconfig-idea-exclude branch May 27, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant