Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-4017 the maven setup does now not contain the wrapper anymore #4

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

Wolf2323
Copy link
Member


  • The main commit(s) reference the Fibery ticket via a TASK-NNNN prefix in the commit message subject
  • Include a human-readable description of what the pull request is trying to accomplish
  • The CI build passes

  • New automated tests have been added
  • The changes are already covered by automated tests and have been adapted
  • These manual test cases cover this change:
  • Steps for the reviewer(s) on how they can manually QA the changes:
  • This is a minor internal change; basic CI/CD coverage is enough
  • This is an incomplete feature hidden behind feature flag:
  • This is proof-of-concept / experimental code not for production / marked @Deprecated
  • No (significant) changes to production code
  • The change also works in LogicTestServer (and does not break it)
  • The change also works in the local Docker Compose environment
  • The change also works under Bedrock edition

  • Classes and public methods have documentation (that doesn't just repeat the technical subject in English)
  • Logging is implemented to monitor feature usage and troubleshoot problems in production
  • These ReWiki pages are affected by this change and will be adapted:

@Wolf2323 Wolf2323 force-pushed the TASK-4017/RemoveWrapper branch 2 times, most recently from 2f119eb to 59c4802 Compare March 14, 2024 13:43
@Wolf2323 Wolf2323 force-pushed the TASK-4017/RemoveWrapper branch from 59c4802 to 57834a0 Compare March 14, 2024 13:49
@Wolf2323 Wolf2323 force-pushed the TASK-4017/RemoveWrapper branch from de175e7 to 305cc2f Compare March 14, 2024 14:34
Copy link
Contributor

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Phoenix616 Phoenix616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wolf2323 Wolf2323 merged commit 93ad45c into main Mar 15, 2024
2 checks passed
@Wolf2323 Wolf2323 deleted the TASK-4017/RemoveWrapper branch March 15, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants