Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error log message #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed error log message #275

wants to merge 2 commits into from

Conversation

gsaslis
Copy link
Contributor

@gsaslis gsaslis commented Jan 12, 2018

Message implies java 8 is fine, but the condition below it does not ;)

Yorgos Saslis and others added 2 commits January 12, 2018 19:51
Fixed error log message
2c36429 
Message implies java 8 is fine, but the condition below it does not ;)
Fixed in build_template also
7a6e5a1 
this way it doesn't get overwritten during build.
@gsaslis
Copy link
Contributor Author

gsaslis commented Jan 16, 2018 •
edited
Loading

@vetss @olenara could you help confirm this is ok?

it came up in some discussions in Gitter and it looks pretty obvious to me that the error message is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gsaslis