Add Rack::Attack #526
Draft
Add Rack::Attack #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| end | ||
|
|
||
| describe "throttle_authenticated_asking" do | ||
| let (:user) { FactoryBot.create(:user) } |
There was a problem hiding this comment.
[Correctable] Lint/ParenthesesAsGroupedExpression: (...) interpreted as grouped expression.
|
|
||
| before(:each) do | ||
| Rack::Attack.enabled = true | ||
| Rack::Attack.reset! |
There was a problem hiding this comment.
[Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 129 129
Lines 2396 2396
=======================================
Hits 2047 2047
Misses 349 349 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds, configures and tests
Rack::Attackfor rate-limiting. Currently only on the/ajax/askendpoint.Due to
AjaxControllersending off it's own responses, this doesn't fully work yet however, because we always return 200 for a successful request, regardless of the middleware saying stuff is throttled or not. This needs a workaround, or needs to wait until #444 is implemented.Fixes #518