-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bulgarian currency formatting #153
base: master
Are you sure you want to change the base?
Conversation
Example: Current format is лв5,335.77 Correct format is 5,335.77 лв.
Reviewer's Guide by SourceryThe PR fixes the Bulgarian currency (BGN) formatting by modifying the template pattern to place the currency symbol (лв) after the amount with a space separator. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HristinaDimova-SumUp - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rhymond A small fix. 👁️
Example:
Current format is лв5,335.77
Correct format is 5,335.77 лв.
Summary by Sourcery
Bug Fixes: