Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #148 #149

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Fix #148 #149

merged 5 commits into from
Aug 6, 2024

Conversation

Dr-Emann
Copy link
Member

@Dr-Emann Dr-Emann commented Aug 5, 2024

We're getting hit by: tokio-rs/tokio#4490 - -Zdirect-minimal-versions doesn't affect path dependencies.

Instead, use cargo-minimal-versions which handles this and some other edge cases with checking against minimal versions.

Currently expecting this to fail because of #148. Once we confirm this would catch such a problem from happening again, this PR will be updated to include a fix.

@Dr-Emann Dr-Emann changed the title Check minimal versions with cargo-minimal-versions Fix #148 Aug 5, 2024
Use the `~` version specifier, which only allows changes in the last digit of
the version. Additionally, force use of version `4.1.1`+, as `4.1.0`
incorrectly claimed the library version in the c code
@Dr-Emann Dr-Emann merged commit 46f226c into RoaringBitmap:master Aug 6, 2024
18 checks passed
@Dr-Emann Dr-Emann deleted the push-utumwmomlylu branch August 6, 2024 00:16
renovate bot referenced this pull request in spiraldb/vortex Aug 6, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [croaring](https://togithub.com/RoaringBitmap/croaring-rs) |
workspace.dependencies | patch | `2.0.2` -> `2.0.3` |

---

### Release Notes

<details>
<summary>RoaringBitmap/croaring-rs (croaring)</summary>

###
[`v2.0.3`](https://togithub.com/RoaringBitmap/croaring-rs/releases/tag/v2.0.3)

[Compare
Source](https://togithub.com/RoaringBitmap/croaring-rs/compare/v2.0.2...v2.0.3)

#### What's Changed

- Use new croaring funcs by
[@&#8203;Dr-Emann](https://togithub.com/Dr-Emann) in
[https://github.com/RoaringBitmap/croaring-rs/pull/141](https://togithub.com/RoaringBitmap/croaring-rs/pull/141)
- Bump cc from 1.0.104 to 1.1.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/RoaringBitmap/croaring-rs/pull/144](https://togithub.com/RoaringBitmap/croaring-rs/pull/144)
- Bump roaring from 0.10.5 to 0.10.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/RoaringBitmap/croaring-rs/pull/142](https://togithub.com/RoaringBitmap/croaring-rs/pull/142)
- Bump to croaring 4.1.1 by
[@&#8203;Dr-Emann](https://togithub.com/Dr-Emann) in
[https://github.com/RoaringBitmap/croaring-rs/pull/147](https://togithub.com/RoaringBitmap/croaring-rs/pull/147)
- Fix
[#&#8203;148](https://togithub.com/RoaringBitmap/croaring-rs/issues/148)
by [@&#8203;Dr-Emann](https://togithub.com/Dr-Emann) in
[https://github.com/RoaringBitmap/croaring-rs/pull/149](https://togithub.com/RoaringBitmap/croaring-rs/pull/149)
- missed update to Cargo.lock for croaring 2.0.3 by
[@&#8203;Dr-Emann](https://togithub.com/Dr-Emann) in
[https://github.com/RoaringBitmap/croaring-rs/pull/150](https://togithub.com/RoaringBitmap/croaring-rs/pull/150)

**Full Changelog**:
RoaringBitmap/croaring-rs@v2.0.2...v2.0.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/spiraldb/vortex).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Dr-Emann Dr-Emann mentioned this pull request Sep 8, 2024
@Dr-Emann Dr-Emann mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant