Merge pull request #412 from wjohnson-aurora/master

Use io.ReadFull in roaring64.Bitmap.ReadFrom
RoaringBitmap · Jan 29, 2024 · aec9bd4 · aec9bd4
2 parents 0d5af75 + 8c5bae9
commit aec9bd4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/roaring64/roaring64.go b/roaring64/roaring64.go
@@ -135,8 +135,8 @@ func (rb *Bitmap) FromUnsafeBytes(data []byte) (p int64, err error) {
 func (rb *Bitmap) ReadFrom(stream io.Reader) (p int64, err error) {
 	sizeBuf := make([]byte, 8)
 	var n int
-	n, err = stream.Read(sizeBuf)
-	if n == 0 || err != nil {
+	n, err = io.ReadFull(stream, sizeBuf)
+	if err != nil {
 		return int64(n), err
 	}
 	p += int64(n)
@@ -159,8 +159,8 @@ func (rb *Bitmap) ReadFrom(stream io.Reader) (p int64, err error) {
 	}
 	keyBuf := sizeBuf[:4]
 	for i := uint64(0); i < size; i++ {
-		n, err = stream.Read(keyBuf)
-		if n == 0 || err != nil {
+		n, err = io.ReadFull(stream, keyBuf)
+		if err != nil {
 			return int64(n), fmt.Errorf("error in bitmap.readFrom: could not read key #%d: %s", i, err)
 		}
 		p += int64(n)