-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vue-popperjs 3.0 - Upgrade to Popper.js v2.x #133
base: master
Are you sure you want to change the base?
vue-popperjs 3.0 - Upgrade to Popper.js v2.x #133
Conversation
https://popper.js.org/docs/v2/migration-guide/#4-remove-all-css-margins Additionally I updated the styles to (nearly) match the tutorial (https://popper.js.org/docs/v2/tutorial/).
You can use setOptions method to change the scroll/resize options at will to replicate the original functionality here, but I did not notice any reason to do this. The resize/scroll listeners appear to be getting added/removed upon toggling the tooltip without any workaround here. https://popper.js.org/docs/v2/migration-guide/#8-update-method-names
I think rollup might needs to be upgraded to support the scoped packages (which popper.js v2 now uses). I will investigate further later (have to get back to day job 😃) Edit: fixed via configure global '@popperjs/core': 'Popper' (edbf63d) |
@curtisbelt I tested your draft proposal for the upgrade to popper v2. |
Hi, some info concerning the evolution of this pull-request? |
Good effort going to taste?! 🤔 yikes! |
This should be a pretty solid start for #127
I followed the migration guide here: https://popper.js.org/docs/v2/migration-guide/
To Do
boundaries-selector
(b8c47b1) -- need to fix it.Possible Additional Changes?
gpuAcceleration: false
from our default options? See vue-popperjs 3.0 - Upgrade to Popper.js v2.x #133 (comment) below.Testing Needed
this.popperJS.enableEventListeners();
andthis.popperJS.disableEventListeners();
was removed via d51caa4 because the methods were removed in Popper v2. I did not replace the logic however, as I noticed the scroll/resize listeners in browser and successfully enabled whenshowPopper: true
and disabled whenshowPopper: false
.Breaking Changes
4. Remove all CSS margins
and5. Ensure your popper and arrow box size is constant for all placements
of the migration guide. I went further and made the styles completely match their tutorial to make sure it's styled as popper.js expects - and I thought it might bring some consistency.