Merge branch 'yeast_stuff' into data_modeling_fixes

RobokopU24 · Feb 5, 2024 · 1dd32df · 1dd32df
2 parents 3c39ead + a7b53d9
commit 1dd32df
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/parsers/SGD/src/loadSGD.py b/parsers/SGD/src/loadSGD.py
@@ -124,7 +124,7 @@ def get_latest_source_version(self) -> str:
         # not exactly right because we also get data from http://ontologies.berkeleybop.org/apo.obo for this currently
         yeastmine_release_response = requests.get('https://yeastmine.yeastgenome.org/yeastmine/service/version/release')
         release_text = yeastmine_release_response.text
-        release_version = release_text.split('Data Updated on:')[1].split('; GO-Release')[0]
+        release_version = release_text.split('Data Updated on:')[1].split('; GO-Release')[0].strip()
         return release_version
 
     def get_data(self) -> int:

diff --git a/parsers/yeast/src/loadCostanza2016.py b/parsers/yeast/src/loadCostanza2016.py
@@ -59,7 +59,7 @@ def get_latest_source_version(self) -> str:
         """
         yeastmine_release_response = requests.get('https://yeastmine.yeastgenome.org/yeastmine/service/version/release')
         release_text = yeastmine_release_response.text
-        release_version = release_text.split('Data Updated on:')[1].split('; GO-Release')[0]
+        release_version = release_text.split('Data Updated on:')[1].split('; GO-Release')[0].strip()
         return release_version
 
     def get_data(self) -> int:

diff --git a/parsers/yeast/src/loadHistoneMap.py b/parsers/yeast/src/loadHistoneMap.py
@@ -202,9 +202,9 @@ def fetch_histone_data(self,
                             'H4K8ac': None, 'H4R3me': None, 'H4R3me2s': None, 'HTZ1': None}
 
         # Will continue to work on this mapping.
-        # Get descendants of GO term "histone modification" (GO:0016570)
+        # Get descendants of GO term "histone modifying activity" (GO:0140993)
         HisModDescendants = rq.get(
-            f"https://www.ebi.ac.uk/QuickGO/services/ontology/go/terms/{'GO:0016570'}/descendants").json()
+            f"https://www.ebi.ac.uk/QuickGO/services/ontology/go/terms/GO:0140993/descendants").json()
         descendants = str(HisModDescendants['results'][0]['descendants']).replace("'", "").replace(" ", "").replace(
             "[", "").replace("]", "")
         descendantNames = rq.get(f"https://www.ebi.ac.uk/QuickGO/services/ontology/go/terms/{descendants}").json()