Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/remove nodenorm #275

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Update/remove nodenorm #275

merged 1 commit into from
Mar 19, 2024

Conversation

Woozl
Copy link
Member

@Woozl Woozl commented Mar 19, 2024

No description provided.

@Woozl Woozl changed the base branch from main to staging March 19, 2024 18:13
@Woozl Woozl marked this pull request as ready for review March 19, 2024 19:17
@Woozl
Copy link
Member Author

Woozl commented Mar 19, 2024

This was originally created to support the yobokop UI, which has a lot of nodes not in babel, so they returned null in the call to nodenorm. After discussing, it doesn't seem that we need the call to nodenorm in the main UI either, as calls to nameres will always have the preferred identifier.

@Woozl Woozl merged commit 1416c7d into staging Mar 19, 2024
3 checks passed
@Woozl Woozl deleted the update/remove-nodenorm branch March 19, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Woozl