Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add itkwidgets examples to jupyter notebook #13182

Closed
wants to merge 1 commit into from

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Apr 30, 2020

Relates #12645.


This change is Reviewable

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @BetsyMcPhail)

a discussion (no related file):
Thanks for packaging this!

That being said, is it possible to also show examples of doing "toy" animations with these different options?
e.g. for meshes / points, can they be animated to rotate and "orbit" around a 3d point?

I would like to know what these look like if we were to do an animation, as indicated here:
https://nbviewer.jupyter.org/github/RobotLocomotion/drake/blob/nightly-release/tutorials/pyplot_animation_multibody_plant.ipynb#Run-with-Playback



tutorials/3dvisualization_tests.ipynb, line 91 at r1 (raw file):

   "outputs": [],
   "source": [
    "view(geometries=bunny)"

nit (super minor) Is it possible to hide the widgets when first displaying?


tutorials/3dvisualization_tests.ipynb, line 316 at r1 (raw file):
For some reason, this isn't rendering as a 3d widget for me; it's just a matplotlib-looking static plot:

image.png

Is there a package missing, or some config bit that needs to be flipped?

FTR, the link you provided here is able to render as a 3D widget.

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented May 21, 2020

I am going to point some other people here to try these out; FTR, on my machine, I used a modified version of these instructions:
https://github.com/RobotLocomotion/drake/tree/653c35dfc75df59dce8a84ab25eef5370f6c274e/.binder

# Git stuff
git fetch upstream master
git fetch upstream pull/13182/head
git checkout -B feature-itkwidgets FETCH_HEAD
git rebase upstream/master

# Docker stuff
docker build -f .binder/Dockerfile -t binder .
docker run --rm -it --name mybinder -p 8888:8888 binder

@jamiesnape
Copy link
Contributor

@drake-jenkins-bot linux-focal-gcc-bazel-experimental-release please

@EricCousineau-TRI
Copy link
Contributor

Given that Russ has a solution direction with meshcat in #12645, I'll close this for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants