Install .pyi files #18074
Install .pyi files #18074
Conversation
This reverts commit 9a0f31a, effectively re-applying commit a61a184. Add rules to generate (as part of the build) and install type stubs for pydrake. Modify wheel build to include these as well. Note that this makes numpy and matplotlib build-time dependencies. (Previously they were only required to test/run pydrake.) Note also that there are issues remaining with the .pyi's; in particular, they are completely unusable by mypy.
jwnimmer-tri
added
priority: medium
status: single reviewer ok
|
@drake-jenkins-bot linux-focal-unprovisioned-gcc-wheel-experimental-snopt-mosek-release please |
|
+@rpoyner-tri for both reviews per schedule, please. Note that r1 contains an unrevert so hopefully can be mostly glossed over. The r2 is the new fixes, just a few list-of-modules tweaks. |
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
jwnimmer-tri
added
the
status: squashing now
Towards #16987.
This reverts commit 9a0f31a (#17746), effectively re-applying commit a61a184 (#17709).
The plan is to squash this on merge; the two commits are for review purposes only.
Add rules to generate (as part of the build) and install type stubs for pydrake. Modify wheel build to include these as well.
Note that this makes numpy and matplotlib build-time dependencies. (Previously they were only required to test/run pydrake.)
Note also that there are issues remaining with the .pyi's; in particular, they are completely unusable by mypy.
This change is