[py optimization] Add missing repr and docs for polytope options #20181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
release notes: fix
The lack of a repr() leads to hex spam in the website API reference.
jwnimmer-tri
force-pushed
the
py-cspace-options-repr
branch
from
24c6923 to
4a387b5
Compare
|
+@sherm1 for both reviews per schedule, please. \CC @AlexandreAmice @ggould-tri @hongkai-dai FYI |
hongkai-dai
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee sherm1(platform), needs at least two assigned reviewers
sherm1
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers
sherm1
added
the
status: single reviewer ok
sherm1
reviewed
Sep 13, 2023
There was a problem hiding this comment.
+(status: single reviewer ok)
Reviewable status:
complete! all discussions resolved, LGTM from assignee sherm1(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of a
repr()leads to hex spam in the website API reference.Amends #19574.
This change is