[py rational] Fix signatures to use Python types (not C++) #21917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
changed the title
Adjust bindings to follow topological order, so that function signatures can look up their requisite python types.
jwnimmer-tri
force-pushed
the
pybind11-check-signature-infection-planning-rational
branch
from
9cf6905 to
cb4d50e
Compare
jwnimmer-tri
added
priority: high
status: single reviewer ok
|
+@sammy-tri for platform review (load balancing), please. |
sammy-tri
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignee sammy-tri(platform)
sammy-tri
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
jwnimmer-tri
deleted the
pybind11-check-signature-infection-planning-rational
branch
RussTedrake
pushed a commit
to RussTedrake/drake
that referenced
this pull request
Dec 15, 2024
…motion#21917) Adjust bindings to follow topological order, so that function signatures can look up their requisite python types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #17520.
The best place to see the resulting effects is the docs. Here's one example of broken docs / types: RationalForwardKinematics.
This change is