Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Create unicode_tables.py #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

legendre6891
Copy link

Added tables that directly uses Unicode characters. Useful for outputting outputs that do not support terminal control characters.

I'm using this for outputting tables in a Jupyter notebook kernel.

Added tables that directly uses Unicode characters. Useful for outputting outputs that do not support terminal control characters.
Copy link
Owner

@Robpol86 Robpol86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include noqa import lines in terminaltables/__init__.py too like the other tables?


class UnicodeSingleTable(AsciiTable):
"""Draw a table using box-drawing characters.
"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove newline from here so both """ are on the same line as per pep8.


class UnicodeDoubleTable(AsciiTable):
"""Draw a table using double lined box-drawing characters.
"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

bobwhitelock added a commit to bobwhitelock/terminaltables that referenced this pull request May 27, 2017
So can be imported in the same way as the other table types; as
requested in Robpol86#42.
bobwhitelock added a commit to bobwhitelock/terminaltables that referenced this pull request May 27, 2017
@bobwhitelock
Copy link

I was having issues in my program with the normal terminaltables output being messed up when piped through less; I switched to using a table from this PR and it solved it perfectly, so thanks!

@legendre6891: I hope you don't mind but I've pushed a couple of commits to another branch to address the requested changes and try and help make this mergeable upstream, feel free to make the changes yourself if you prefer however.

bobwhitelock added a commit to bobwhitelock/doctor that referenced this pull request May 27, 2017
So output displays correctly in less; previously the tables were messing
up all the output. Refer to:
Robpol86/terminaltables#42.
@legendre6891
Copy link
Author

Hi, glad you found it useful. I apologize for the bad etiquette for not responding to the changes --- caught up with school at the moment. Please feel free to merge your branch, thanks!

All the best.

@anarcat anarcat mentioned this pull request Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants