-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure hovered option gets un-hovered properly #1412
base: main
Are you sure you want to change the base?
Conversation
|
|
Hey maintainer, Can you please review this pull request? |
Hey @umangutkarsh can you please review this pull request? So that if there are any changes to be made I can follow up |
Proposed changes (including videos or screenshots)
This was a basic one line fix, in the
MenuOption.tsx
. I had removed'rcx-option--focus',
from the linefocus && 'rcx-option--focus',
in the className array, due to thatand
condition the class was not getting removed even if the item is unhovered.Screencast.from.2024-07-22.20-28-12.webm
Issue:
Fixes: #1361
Further comments