Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Issue #91: team-02 - Mean trajectory dispersion simulation #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SullivanMuse
Copy link

Pull request type

Please check the type of change your PR introduces:

  • [*] Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

There are no utilities for dispersion analysis.

What is the new behavior?

Utilities are added to allow easy visualization of the results of dispersion analyses. One can simple pass a list of Flights to plot_dispersion. Each flight trajectory is converted from the time domain to the non-dimensional time domain (non-dimensionalized by the duration) and interpolated to a standard number of points (default 1000). Then mean, and standard deviation (in z-axis only) flight trajectories are calculated. Finally, all trajectories are plotted. Real trajectories are plotted in black. Statistical trajectories are plotted in red.

Does this introduce a breaking change?

  • Yes
  • [*] No

Other information

This could definitely use some tests. Also, it introduces a lot of new utility functions.

See screenshot of simple example:

image

@giovaniceotto giovaniceotto linked an issue Aug 28, 2022 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR changed the title Mean trajectory dispersion simulation #91 Issue #91: team-02 - Mean trajectory dispersion simulation Aug 28, 2022
Copy link
Member

@giovaniceotto giovaniceotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @SullivanMuse! This is a great solution to the problem. Kudos for normalizing the time vector and making sure to make time steps uniform.

I ran your notebook here with some more flights and kept getting a great result:
image

@giovaniceotto giovaniceotto added the 50 points Hard challengs! label Aug 28, 2022
@Gui-FernandesBR
Copy link
Member

Awesome!!

@Gui-FernandesBR
Copy link
Member

May recieve an extra 20% points since it was the onlly team solving this challege

@Gui-FernandesBR Gui-FernandesBR added the extra_points Exceptionally ingenious solutions label Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
50 points Hard challengs! extra_points Exceptionally ingenious solutions team-02
Projects
Development

Successfully merging this pull request may close these issues.

Mean trajectory dispersion simulation
3 participants