Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Issue #7: team-05 - New tail shapes #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sofia-ME
Copy link

Pull request type

Please check the type of change your PR introduces:

  • [X ] Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

Enter text here...

What is the new behavior?

addTail new geometries

Does this introduce a breaking change?

  • Yes
  • No

Other information

Enter text here...

@Gui-FernandesBR Gui-FernandesBR changed the title Issue#7 : team05 Issue #7: team-05 - New tail shapes Aug 29, 2022
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 29, 2022 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR removed the request for review from giovaniceotto August 29, 2022 05:40
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 29, 2022 that may be closed by this pull request
@brunosorban
Copy link

Hey, nice work implementing new tail shapes! There are two issues that prevent the code from properly working:

  1. In "circular arc", the operator "^" was used instead of "**"

  2. In "parabolic PS" there is a division by 0 if "n=0".

The first is a minor issue, but the second should be a feature. There are also "elliptical" and "parabolic PS (n=1)" shapes that work just perfectly, so only 20% of the points will be discounted. The documentation was also good so, overall, a good Pull Request!

@brunosorban brunosorban added 25 points Medium challenges! penalty Solutions poorly documented or badly coded labels Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
25 points Medium challenges! penalty Solutions poorly documented or badly coded team-05
Projects
Development

Successfully merging this pull request may close these issues.

New Tail Shapes
4 participants