Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Issue #14: team-05 - Simulate until rocket is out of rail #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GustavoSaturnino
Copy link

I've changed "Flight" to TerminateOnRail works.
Attention to "Flight Trajectory" graph.

@GustavoSaturnino GustavoSaturnino changed the title Changes in "Flight" to terminate on rail issue_#14_UnbreakableTeam Aug 27, 2022
@Gui-FernandesBR Gui-FernandesBR self-requested a review August 27, 2022 16:05
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 27, 2022 that may be closed by this pull request
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important addition to run Out of Rail Speed as a Function of Mass analysis faster! I've tested and approved the PR with only one minor change suggested, good job!

image

image

self.solution[-1] = [self.t, *self.state]
# Set last flight phase
self.flightPhases.flushAfter(phase_index)
print(self.t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(self.t)

@Gui-FernandesBR Gui-FernandesBR added the 10 points Easy challenges! label Aug 27, 2022
@Gui-FernandesBR Gui-FernandesBR changed the title issue_#14_UnbreakableTeam Issue #14: UnbreakableTeam Aug 27, 2022
@Gui-FernandesBR Gui-FernandesBR changed the title Issue #14: UnbreakableTeam Issue #14: team-05 - Simulate until rocket is out of rail Aug 27, 2022
@Gui-FernandesBR Gui-FernandesBR removed the request for review from giovaniceotto August 29, 2022 05:46
@Gui-FernandesBR Gui-FernandesBR added Easy and removed Easy labels Sep 3, 2022
@Gui-FernandesBR
Copy link
Member

May recieve an extra 20% points since it was the onlly team solving this challege

@Gui-FernandesBR Gui-FernandesBR added the extra_points Exceptionally ingenious solutions label Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
10 points Easy challenges! extra_points Exceptionally ingenious solutions team-05
Projects
Development

Successfully merging this pull request may close these issues.

Simulate until rocket is out of rail
3 participants