Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Lince (Team STAR) 2023 flight sim #752

Merged
merged 15 commits into from
Dec 15, 2024

Conversation

LUCKIN13
Copy link
Contributor

@LUCKIN13 LUCKIN13 commented Dec 11, 2024

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Additional information

Unfortunately I couldn't find any GNSS flight data from the payload. However, this is still a really good example of a simulation model with deployable payload.

@LUCKIN13 LUCKIN13 requested a review from a team as a code owner December 11, 2024 19:47
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plot isn't correct.
The flight should stop at the main deployment height.
You should set a max_time for the first flight object.

image

Also, how did you generate the initial solution for other flights?

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add this flight to the comparison plot on the index.rst file

@LUCKIN13
Copy link
Contributor Author

Also, please add this flight to the comparison plot on the index.rst file

Sorry for forgetting that. Will do that asap

@LUCKIN13 LUCKIN13 self-assigned this Dec 14, 2024
@Gui-FernandesBR
Copy link
Member

@LUCKIN13 try to read my last commit, I think the #735 solved the problem with the wind speeds.
The problematic code was related to the environment class, not the .nc file, so I've deleted your new file and preserved only the old one.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gui-FernandesBR Gui-FernandesBR merged commit f407559 into develop Dec 15, 2024
1 check passed
@Gui-FernandesBR Gui-FernandesBR deleted the docs/star-2023-flight-sim branch December 15, 2024 02:30
@LUCKIN13
Copy link
Contributor Author

@LUCKIN13 try to read my last commit, I think the #735 solved the problem with the wind speeds. The problematic code was related to the environment class, not the .nc file, so I've deleted your new file and preserved only the old one.

Great! Makes sense, since all the other examples also add some problems. Thanks a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants