Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PickFile and PickDirectory #1232

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

manandre
Copy link
Contributor

Fixes #1003

Cache must only contain existing paths
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 8.14%. Comparing base (5c733cb) to head (80abfa3).

Files Patch % Lines
src/Nuke/FilePathExtensions.cs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1232      +/-   ##
=========================================
- Coverage    8.19%   8.14%   -0.05%     
=========================================
  Files         146     146              
  Lines        3638    3632       -6     
  Branches      287     285       -2     
=========================================
- Hits          298     296       -2     
+ Misses       3340    3336       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-driscoll
Copy link
Member

Thanks for the find @manandre !

@david-driscoll david-driscoll merged commit 4c6752e into RocketSurgeonsGuild:master Jun 15, 2024
8 of 9 checks passed
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Jun 15, 2024
@david-driscoll david-driscoll added 🐞 bug Something isn't working and removed ✨ mysterious We forgot to label this labels Jun 15, 2024
@manandre manandre deleted the fix-pick branch June 15, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating to version 1.8.0 fails with "default.runsettings could not be found."
2 participants