Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract parse() function, and add unittest for Diceparser #15

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Extract parse() function, and add unittest for Diceparser #15

wants to merge 6 commits into from

Commits on Jun 3, 2018

  1. make Die mockable

    Robin Moussu committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    7e526ae View commit details
    Browse the repository at this point in the history

  2. wip: extract parse function (need to be move in a better file)

    Robin Moussu committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    e1fa9ab View commit details
    Browse the repository at this point in the history

  3. wip: add unit test (7/29 pass, I'm investigating why)

    Robin Moussu committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    e3db79e View commit details
    Browse the repository at this point in the history

  4. add debug flag

    Robin Moussu committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    cb20da0 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2018

  1. It look like 'g' isn't working either in all cases :(

    Robin Moussu committed Jun 9, 2018
    Configuration menu
    Copy the full SHA
    1b00f06 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2018

  1. fix random generator mocking 

    The value generated by a random generator is scaled down to match the
interval of the desired value. I assumed it was using modulo, not divide,
to scale down, but I was wrong. So I added a parameter to the mock to
specify the range of the desired values. It's a quirk to have a scale
of 1, and thus no scaling.
    Robin Moussu committed Jun 10, 2018
    Configuration menu
    Copy the full SHA
    fdf87e3 View commit details
    Browse the repository at this point in the history