refactor(test): Updating tests phpdoc to PHP Attributes

Roskus · Sep 8, 2024 · bcae008 · bcae008
1 parent 76ed41a
commit bcae008
Show file tree

Hide file tree

Showing 62 changed files with 143 additions and 93 deletions.
diff --git a/tests/Feature/Console/Commands/ScheduleNotificationReminderTest.php b/tests/Feature/Console/Commands/ScheduleNotificationReminderTest.php
@@ -9,11 +9,12 @@
 use App\Models\Lead;
 use Illuminate\Support\Carbon;
 use Illuminate\Support\Facades\Mail;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class ScheduleNotificationReminderTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_send_notifications(): void
     {
         Mail::fake();
@@ -41,7 +42,7 @@ public function it_can_send_notifications(): void
         });
     }
 
-    /** @test */
+    #[Test]
     public function it_can_store_notifications(): void
     {
         $timezone = 'Europe/Madrid';

diff --git a/tests/Feature/Controllers/Api/Auth/LoginControllerTest.php b/tests/Feature/Controllers/Api/Auth/LoginControllerTest.php
@@ -4,11 +4,14 @@
 
 namespace Tests\Feature\Controllers\Api\Auth;
 
+use PHPUnit\Framework\Attributes\CoversMethod;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class LoginControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
+    //#[CoversMethod('App\Http\Controllers\Api\Auth\LoginController', 'login')]
     public function it_can_login()
     {
         $credentials = ['email' => $this->user->email, 'password' => 'password'];
@@ -23,7 +26,7 @@ public function it_can_login()
         $this->isAuthenticated('api');
     }
 
-    /** @test */
+    #[Test]
     public function it_can_not_login_with_wrong_credentials()
     {
         $credentials = ['email' => $this->user->email, 'password' => 'wrong_password'];
@@ -36,7 +39,7 @@ public function it_can_not_login_with_wrong_credentials()
         $this->assertGuest('api');
     }
 
-    /** @test */
+    #[Test]
     public function it_can_get_credentials()
     {
         $this->actingAs($this->user, 'api');
@@ -48,7 +51,7 @@ public function it_can_get_credentials()
             ->assertExactJson($this->user->toArray());
     }
 
-    /** @test */
+    #[Test]
     public function it_can_logout()
     {
         $credentials = ['email' => $this->user->email, 'password' => 'password'];
@@ -64,7 +67,7 @@ public function it_can_logout()
         $this->assertGuest('api');
     }
 
-    /** @test */
+    #[Test]
     public function it_can_refresh_token()
     {
         $credentials = ['email' => $this->user->email, 'password' => 'password'];

diff --git a/tests/Feature/Controllers/Api/Contact/ContactCreateControllerTest.php b/tests/Feature/Controllers/Api/Contact/ContactCreateControllerTest.php
@@ -6,17 +6,16 @@
 
 use App\Models\Industry;
 use App\Models\Lead;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class ContactCreateControllerTest extends TestCase
 {
-    protected $jsonStructureContact = [
+    protected array $jsonStructureContact = [
         'id',
     ];
 
-    /**
-     * @test
-     */
+    #[Test]
     public function can_create_contact(): void
     {
         $this->actingAs($this->user, 'api');
@@ -60,9 +59,7 @@ public function can_create_contact(): void
             ->assertSee($data['contact_phone']);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function create_contact_have_missing_parameters(): void
     {
         $this->actingAs($this->user, 'api');

diff --git a/tests/Feature/Controllers/Api/Customer/CustomerCreateControllerTest.php b/tests/Feature/Controllers/Api/Customer/CustomerCreateControllerTest.php
@@ -4,11 +4,12 @@
 
 use App\Models\Customer;
 use App\Models\User;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class CustomerCreateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_save_customer(): void
     {
         $this->actingAs(User::factory()->create(), 'api');

diff --git a/tests/Feature/Controllers/Api/Customer/CustomerListControllerTest.php b/tests/Feature/Controllers/Api/Customer/CustomerListControllerTest.php
@@ -4,11 +4,12 @@
 
 use App\Models\Customer;
 use App\Models\User;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class CustomerListControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_list_customer(): void
     {
         $this->actingAs(User::factory()->create(), 'api');

diff --git a/tests/Feature/Controllers/Api/Customer/CustomerReadControllerTest.php b/tests/Feature/Controllers/Api/Customer/CustomerReadControllerTest.php
@@ -4,11 +4,12 @@
 
 use App\Models\Customer;
 use App\Models\User;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class CustomerReadControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_read_customer(): void
     {
         $this->actingAs(User::factory()->create(), 'api');
@@ -19,7 +20,7 @@ public function it_can_read_customer(): void
         $this->assertEquals(array_except($response->json()['customer'], ['seller', 'industry', 'country']), $customer->toArray());
     }
 
-    /** @test */
+    #[Test]
     public function it_not_found_a_customer(): void
     {
         $this->actingAs(User::factory()->create(), 'api');

diff --git a/tests/Feature/Controllers/Api/Customer/CustomerUpdateControllerTest.php b/tests/Feature/Controllers/Api/Customer/CustomerUpdateControllerTest.php
@@ -1,14 +1,17 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Tests\Feature\Controllers\Api\Customer;
 
 use App\Models\Customer;
 use App\Models\User;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class CustomerUpdateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_update_customer(): void
     {
         $this->actingAs(User::factory()->create(), 'api');

diff --git a/tests/Feature/Controllers/Api/Lead/LeadCreateControllerTest.php b/tests/Feature/Controllers/Api/Lead/LeadCreateControllerTest.php
@@ -4,11 +4,12 @@
 
 use App\Models\Lead;
 use App\Models\User;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class LeadCreateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_save_lead(): void
     {
         $this->actingAs(User::factory()->create(), 'api');

diff --git a/tests/Feature/Controllers/Api/Lead/LeadListControllerTest.php b/tests/Feature/Controllers/Api/Lead/LeadListControllerTest.php
@@ -4,11 +4,12 @@
 
 use App\Models\Lead;
 use App\Models\User;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class LeadListControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_list_lead(): void
     {
         $this->actingAs(User::factory()->create(), 'api');

diff --git a/tests/Feature/Controllers/Api/Lead/LeadReadControllerTest.php b/tests/Feature/Controllers/Api/Lead/LeadReadControllerTest.php
@@ -4,11 +4,12 @@
 
 use App\Models\Lead;
 use App\Models\User;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class LeadReadControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_read_lead(): void
     {
         $this->actingAs(User::factory()->create(), 'api');
@@ -19,7 +20,7 @@ public function it_can_read_lead(): void
         $this->assertEquals(array_except($response->json()['lead'], ['seller', 'industry', 'country', 'company']), $lead->toArray());
     }
 
-    /** @test */
+    #[Test]
     public function it_not_found_a_lead(): void
     {
         $this->actingAs(User::factory()->create(), 'api');

diff --git a/tests/Feature/Controllers/Api/Lead/LeadUpdateControllerTest.php b/tests/Feature/Controllers/Api/Lead/LeadUpdateControllerTest.php
@@ -4,11 +4,12 @@
 
 use App\Models\Lead;
 use App\Models\User;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class LeadUpdateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_update_lead(): void
     {
         $this->actingAs(User::factory()->create(), 'api');

diff --git a/tests/Feature/Controllers/Bank/BankCreateControllerTest.php b/tests/Feature/Controllers/Bank/BankCreateControllerTest.php
@@ -2,11 +2,12 @@
 
 namespace Tests\Feature\Controllers\Bank;
 
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BankCreateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_create_bank()
     {
         $response = $this->get('/bank/create');

diff --git a/tests/Feature/Controllers/Bank/BankIndexControllerTest.php b/tests/Feature/Controllers/Bank/BankIndexControllerTest.php
@@ -3,11 +3,12 @@
 namespace Tests\Feature\Controllers\Bank;
 
 use App\Models\Bank;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BankIndexControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_index_bank()
     {
         $banks = Bank::factory()->count(2)->create();

diff --git a/tests/Feature/Controllers/Bank/BankSaveControllerTest.php b/tests/Feature/Controllers/Bank/BankSaveControllerTest.php
@@ -3,11 +3,12 @@
 namespace Tests\Feature\Controllers\Bank;
 
 use App\Models\Bank;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BankSaveControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_save_bank(): void
     {
         $data = Bank::factory()->create()->toArray();
@@ -18,7 +19,7 @@ public function it_can_save_bank(): void
         $this->equalTo(Bank::all()->last(), $data);
     }
 
-    /** @test */
+    #[Test]
     public function it_can_update_bank(): void
     {
         $data = Bank::factory()->create()->toArray();

diff --git a/tests/Feature/Controllers/Bank/BankUpdateControllerTest.php b/tests/Feature/Controllers/Bank/BankUpdateControllerTest.php
@@ -3,11 +3,12 @@
 namespace Tests\Feature\Controllers\Bank;
 
 use App\Models\Bank;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BankUpdateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_update_bank(): void
     {
         $bank = Bank::factory()->create();

diff --git a/tests/Feature/Controllers/Brand/BrandCreateControllerTest.php b/tests/Feature/Controllers/Brand/BrandCreateControllerTest.php
@@ -2,11 +2,12 @@
 
 namespace Tests\Feature\Controllers\Brand;
 
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BrandCreateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_create_brand()
     {
         $response = $this->get('/brand/create');

diff --git a/tests/Feature/Controllers/Brand/BrandDeleteControllerTest.php b/tests/Feature/Controllers/Brand/BrandDeleteControllerTest.php
@@ -3,11 +3,12 @@
 namespace Tests\Feature\Controllers\Brand;
 
 use App\Models\Brand;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BrandDeleteControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_delete_brand()
     {
         $brand = Brand::factory()->create();

diff --git a/tests/Feature/Controllers/Brand/BrandIndexControllerTest.php b/tests/Feature/Controllers/Brand/BrandIndexControllerTest.php
@@ -3,11 +3,12 @@
 namespace Tests\Feature\Controllers\Brand;
 
 use App\Models\Brand;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BrandIndexControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_index_brand()
     {
         $brands = Brand::factory()->count(2)->create(['company_id' => $this->user->company_id]);

diff --git a/tests/Feature/Controllers/Brand/BrandSaveControllerTest.php b/tests/Feature/Controllers/Brand/BrandSaveControllerTest.php
@@ -3,11 +3,12 @@
 namespace Tests\Feature\Controllers\Brand;
 
 use App\Models\Brand;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BrandSaveControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_save_brand(): void
     {
         $data = Brand::factory()->create(['company_id' => $this->user->company_id])->toArray();
@@ -18,7 +19,7 @@ public function it_can_save_brand(): void
         $this->equalTo(Brand::all()->last(), $data);
     }
 
-    /** @test */
+    #[Test]
     public function it_can_update_brand(): void
     {
         $data = Brand::factory()->create(['company_id' => $this->user->company_id])->toArray();

diff --git a/tests/Feature/Controllers/Brand/BrandUpdateControllerTest.php b/tests/Feature/Controllers/Brand/BrandUpdateControllerTest.php
@@ -3,11 +3,12 @@
 namespace Tests\Feature\Controllers\Brand;
 
 use App\Models\Brand;
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class BrandUpdateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_update_brand(): void
     {
         $brand = Brand::factory()->create();

diff --git a/tests/Feature/Controllers/Company/CompanyCreateControllerTest.php b/tests/Feature/Controllers/Company/CompanyCreateControllerTest.php
@@ -4,11 +4,12 @@
 
 namespace Tests\Feature\Controllers\Company;
 
+use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
 
 class CompanyCreateControllerTest extends TestCase
 {
-    /** @test */
+    #[Test]
     public function it_can_create_company(): void
     {
         $response = $this->get('/company/create');