[Feature] Adds importable memory. #42
Conversation
may-20i
changed the title
|
Interesting! I like it! It’s definitely a feature we should have. |
| @@ -80,6 +80,12 @@ defmodule Orb.Import do | |||
| end | |||
| end | |||
|
|
|||
| defmacro register_memory(global, namespace, min \\ nil) do | |||
There was a problem hiding this comment.
Curious why register_memory/3 instead of memory/3?
There was a problem hiding this comment.
Just seemed like the thing to do, I was frankly pretty tired when I wrote this so perhaps memory/3 would be more appropriate.
| @@ -3,7 +3,7 @@ defmodule Orb.Memory do | |||
| Work with memory: load, store, declare pages & initial data. | |||
| """ | |||
|
|
|||
| defstruct name: "", min: 0, exported_name: "memory" | |||
| defstruct name: "", min: 0, exported_name: "memory", is_imported?: false | |||
There was a problem hiding this comment.
There‘s a bug from me where we aren’t using the exported_name field in the wat output. So I should fix that.
I think generally it makes sense if you can export xor import, not both. So I’ll have a think about how best to represent that…
There was a problem hiding this comment.
Suggested resolution? Or needs some thinking?
There was a problem hiding this comment.
Sorry work has been super busy, I’ll resolve this soon!
What do you think of something like this for memory imports?