Fixes ruby deprecation warning regarding bigdecimal will be moved out from stdlib soon
#1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec.
|
ty |
tagliala
reviewed
Mar 13, 2024
Comment on lines
+17
to
+18
|
|
||
| s.add_dependency "bigdecimal", "~> 3.1" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('6.19.0') |
There was a problem hiding this comment.
Hello, I have some concerns about this implementation, in example 6.18.0 should be compatible with Ruby 3.4 and it should require bigdecimal.
This is checking that the current RUBY VERSION (3.4 at most) is >= 6.19.0, which will not be the case for the next few years
There was a problem hiding this comment.
would you please submit an alt. will hold any release until we are all satisfied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
When using this gem in a project a warning is thrown.
/usr/local/bundle/gems/money-6.16.0/lib/money.rb:1: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of money-6.16.0 to add bigdecimal into its gemspec.Shopify has a related issue to the topic, see their issue #1772.
What was done
bigdecimalgem to gemspec file with a condition for the used version of the gem