rust: globally warn on unsafe_op_in_unsafe_fn

[ojeda]

This includes non-rust/ code.

As soon as the warnings are cleaned up, we can move it to a hard error.

Fixes: #285

Signed-off-by: Miguel Ojeda [email protected]

[ksquirrel]

Review of 34658e643210:

• ✔️ Commit 34658e6: Looks fine!

[alex]

Let's get a bug to flip it to an error after we've got the warning count to 0.

[ojeda]

Let's get a bug to flip it to an error after we've got the warning count to 0.

+1 I'm on it.

[TheSven73]

Was it such a great idea to merge this in its current form? I am getting tons of build warnings now.

[TheSven73]

warning: 118 warnings emitted
Do we divide up the work between a few volunteers? :)

[nbdd0121]

Well, we need to merge it; unsafe_op_in_unsafe_fn is not a conventional warnings. If you allow it, it will warn about using unsafe in unsafe fn; otherwise if warns about not using unsafe in unsafe fn.

So if we don't merge this we'll have to use #[allow(unused_unsafe)] while doing migration, which means that we won't have warning for either style :)

[TheSven73]

Not disputing that we should merge it... just fell off my chair when I saw the gazillion warnings :)

So do we divvy up these 118 warnings between volunteers? I can help if required.

[ojeda]

Yes please! Follow the discussion in #340.

[ojeda]

Was it such a great idea to merge this in its current form? I am getting tons of build warnings now.

Like Gary explained, it was either that or adding allow everywhere, which is not nice and would create more churn.

If we were in mainline, I would have gone the other way -- but since it is just "us"... better to push everyone to fix them ;)

Not disputing that we should merge it... just fell off my chair when I saw the gazillion warnings :)

Yeah, that is why I tagged it as prio: high -- hopefully in a week or so we have them sorted out.