Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the wasm example from an npm/webpack based approach to trunk. Fixes #834.
Of note:
the
console_error_panic_hook
dependency was gated inCargo.toml
via[target."cfg(debug_assertions)".dependencies]
. This is documented as nonfunctional and will throw a warning on build:Since the actual usage of
console_error_panic_hook
is also gated inlib.rs
behind#[cfg(debug_assertions)]
it didn't make sense to have the cargo gate in place, hence I have removed it.Next steps
If this PR is merged, the wiki page linked in the root README should be updated as well.