Merge pull request #16 from MirkoCovizzi/master

Address interface ordering issue
RustAudio · Apr 27, 2020 · 977a0b2 · 977a0b2
2 parents dfe5e17 + 6c895df
commit 977a0b2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/com/macros/support/src/utils/idents.rs b/com/macros/support/src/utils/idents.rs
@@ -45,8 +45,9 @@ pub fn base_interface_idents(attr_args: &AttributeArgs) -> Vec<Ident> {
 
             for item in &attr.nested {
                 if let NestedMeta::Meta(Meta::Path(p)) = item {
-                    assert!(
-                        p.segments.len() == 1,
+                    assert_eq!(
+                        p.segments.len(),
+                        1,
                         "Incapable of handling multiple path segments yet."
                     );
                     base_interface_idents.push(
@@ -61,6 +62,20 @@ pub fn base_interface_idents(attr_args: &AttributeArgs) -> Vec<Ident> {
         }
     }
 
+    if base_interface_idents.contains(&format_ident!("IComponent")) {
+        assert_eq!(
+            base_interface_idents[0],
+            format_ident!("IComponent"),
+            "IComponent should always be first."
+        );
+    } else if base_interface_idents.contains(&format_ident!("IEditController")) {
+        assert_eq!(
+            base_interface_idents[0],
+            format_ident!("IEditController"),
+            "IEditController should always be first."
+        );
+    }
+
     base_interface_idents
 }
 
@@ -92,8 +107,9 @@ pub fn get_aggr_map(attr_args: &AttributeArgs) -> HashMap<Ident, Vec<Ident>> {
 
             for item in &attr.nested {
                 if let NestedMeta::Meta(Meta::Path(p)) = item {
-                    assert!(
-                        p.segments.len() == 1,
+                    assert_eq!(
+                        p.segments.len(),
+                        1,
                         "Incapable of handling multiple path segments yet."
                     );
                     aggr_interfaces_idents.push(

diff --git a/examples/passthru.rs b/examples/passthru.rs
@@ -37,7 +37,6 @@ unsafe fn wstrcpy(src: &str, dst: *mut c_short) {
 
 #[VST3(implements(
     IComponent,
-    IPluginBase,
     IEditController,
     IAudioProcessor,
     IAutomationState,