Remove unused variables #1034 #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR at RustCrypto/utils#1057 updates the fiat-constify program to filter out
let mutlines that introduced many unused variable and causing #1034. The changes in this PR are the updated output from fiat-constify. Note that running fiat-constify without any changes at all caused substantial changes to the files in this PR. To work around this, I first ran generation without any changes to fiat-constify and committed the changes, I then changed fiat-constify and reran it committing the changes again, and finally reverted the first commit to undo the undesirable changes. I've read through the entire changeset to confirm that only the unused mut variables are removed and no other changes are present.