Fix tests

SAP · Sep 3, 2024 · 0616f55 · 0616f55
1 parent 788db03
commit 0616f55
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...s/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiStreamingHandler.java b/...s/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiStreamingHandler.java
@@ -82,7 +82,7 @@ private Stream<D> parseResponse(@Nonnull final ClassicHttpResponse response)
         .onClose(
             () -> {
               try {
-                inputStream.close();
+                br.close();
               } catch (IOException e) {
                 log.error("Could not close HTTP input stream", e);
               }

diff --git a/...-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientTest.java b/...-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientTest.java
@@ -23,6 +23,7 @@
 import com.sap.ai.sdk.foundationmodels.openai.model.OpenAiContentFilterPromptResults;
 import com.sap.ai.sdk.foundationmodels.openai.model.OpenAiEmbeddingParameters;
 import com.sap.cloud.sdk.cloudplatform.connectivity.ApacheHttpClient5Accessor;
+import com.sap.cloud.sdk.cloudplatform.connectivity.ApacheHttpClient5Cache;
 import com.sap.cloud.sdk.cloudplatform.connectivity.DefaultHttpDestination;
 import io.vavr.control.Try;
 import java.io.IOException;
@@ -50,6 +51,8 @@ void setup(WireMockRuntimeInfo server) {
     final DefaultHttpDestination destination =
         DefaultHttpDestination.builder(server.getHttpBaseUrl()).build();
     client = OpenAiClient.withCustomDestination(destination);
+    ApacheHttpClient5Accessor.setHttpClientCache(ApacheHttpClient5Cache.DISABLED);
+    ApacheHttpClient5Accessor.setHttpClientFactory(null);
   }
 
   @Test
@@ -162,7 +165,7 @@ void chatCompletion() throws IOException {
 
       assert inputStream != null;
       final String response = new String(inputStream.readAllBytes());
-      stubFor(post(anyUrl()).willReturn(okJson(response)));
+      stubFor(post("/chat/completions").willReturn(okJson(response)));
 
       final var systemMessage =
           new OpenAiChatMessage.OpenAiChatSystemMessage()
@@ -251,7 +254,7 @@ void embedding() throws IOException {
 
       assert inputStream != null;
       final String response = new String(inputStream.readAllBytes());
-      stubFor(post(anyUrl()).willReturn(okJson(response)));
+      stubFor(post("/embeddings").willReturn(okJson(response)));
 
       final var request = new OpenAiEmbeddingParameters().setInput("Hello World");
       final var result = client.embedding(request);