Enabling compilation with JDK23+ #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
reviewed
Nov 12, 2024
| @@ -53,6 +53,7 @@ | |||
| <maven.compiler.source>17</maven.compiler.source> | |||
| <maven.compiler.target>17</maven.compiler.target> | |||
| <maven.compiler.release>17</maven.compiler.release> | |||
| <maven.compiler.proc>full</maven.compiler.proc> | |||
There was a problem hiding this comment.
Annotation processing:
- none - no annotation processing is performed.
- only - only annotation processing is done, no compilation.
- full - annotation processing and compilation.
fullis the default. Starting with JDK 21 (sic), this option must be set explicitly.
More details here:
https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#proc
newtork
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#ISSUENUMBER.(no issue number)Adds compatibility between Lombok and JDK23.
(For more info see here.)
Feature scope:
(not applicable)
Definition of Done
(not applicable)
Functionality scope stated & coveredTests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated