Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI] Enable builder pattern #18

Merged
merged 25 commits into from
Aug 14, 2024
Merged

[OpenAPI] Enable builder pattern #18

merged 25 commits into from
Aug 14, 2024

Conversation

newtork
Copy link
Contributor

@newtork newtork commented Aug 14, 2024

Context

AI/ai-sdk-java-backlog#53.

Enable builder pattern for generated OpenAPI code.

Feature scope:

  • Use builder method create()
    • Update code
    • Update readme
  • Do not use build method

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

newtork and others added 19 commits August 8, 2024 15:26
# Conflicts:
#	core/src/main/java/com/sap/ai/sdk/core/client/ApplicationApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ArtifactApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ConfigurationApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/DeploymentApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/DockerRegistrySecretApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ExecutableApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ExecutionApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ExecutionScheduleApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/FileApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/KpiApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/MetaApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/MetricsApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ModelApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ObjectStoreSecretApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/RepositoryApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ResourceApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ResourceGroupApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ResourceQuotaApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ScenarioApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/SecretApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/ServiceApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentQuotaItem.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentResourceQuotaResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentUsage.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndUsageResourcePlanItem.java
#	e2e-test-app/src/main/java/com/sap/ai/sdk/app/controllers/ModelsController.java
# Conflicts:
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiApiError.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiApiErrorWithId.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiArtifact.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiArtifactArgumentBinding.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiArtifactCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiArtifactList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiArtifactPostData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiConfiguration.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiConfigurationBaseData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiConfigurationCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiConfigurationList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeployment.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentBulkModificationRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentBulkModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentCreationRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentDeletionResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentModificationRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentModificationRequestWithIdentifier.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentModificationResponseListInner.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiDeploymentResponseWithDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiEnactmentCreationRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutable.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutableArtifact.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutableList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutableParameter.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecution.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionBulkModificationRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionBulkModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionDeletionResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionModificationRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionModificationRequestWithIdentifier.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionModificationResponseListInner.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionResponseWithDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionSchedule.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionScheduleCreationData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionScheduleCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionScheduleDeletionResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionScheduleList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionScheduleModificationRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiExecutionScheduleModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiLabel.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiLogCommonData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiLogCommonResultItem.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiModelBaseData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiModelList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiModelVersion.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiParameterArgumentBinding.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiResourcesDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiScalingDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiScenario.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiScenarioLabel.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiScenarioList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiVersion.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/AiVersionList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/ArtifactQuery400Response.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndAllArgoCDApplicationData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationBaseData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationDataRepoName.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationDeletionResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationRefreshResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationStatus.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationStatusSource.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDApplicationStatusSyncResourcesStatusInner.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDRepositoryCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDRepositoryCredentials.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDRepositoryData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDRepositoryDataResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDRepositoryDeletionResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDRepositoryDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndArgoCDRepositoryModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndCommonResourceQuotaResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndCommonResourceQuotaResponseQuota.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndCommonResourceQuotaResponseUsage.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentQuota.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentQuotaItem.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentResourceQuotaResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentUsage.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndError.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndErrorResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndEvent.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndExecutableResourceQuotaResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndExecutableResourceQuotaResponseQuota.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndExecutableResourceQuotaResponseUsage.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndExtendedService.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndGenericSecretDataResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndGenericSecretDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndGenericSecretPatchBody.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndGenericSecretPostBody.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndInternalResourceGroup.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndInternalResourceGroupAnnotation.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndInternalResourceGroupLabel.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndListGenericSecretsResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGetResourcePlansValue.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGetResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGroup.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGroupBase.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGroupDeletionResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGroupLabel.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGroupList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGroupPatchRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourceGroupsPostRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourcePatchBody.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourcePatchNodes.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndResourcePatchResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndService.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceBrokerSecret.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceCapabilities.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceCapabilitiesBasic.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceCapabilitiesLogs.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceServiceCatalogItem.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceServiceCatalogItemExtendCatalog.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceServiceCatalogItemExtendCredentials.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceServiceCatalogItemExtendCredentialsShared.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceServiceCatalogItemExtendCredentialsSharedServiceUrls.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceServicePlanItem.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndServiceServicePlanItemMetadata.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndTenant.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndUsageResourcePlanItem.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BcknddockerRegistrySecretCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BcknddockerRegistrySecretDeletionResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BcknddockerRegistrySecretModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BcknddockerRegistrySecretStatus.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BcknddockerRegistrySecretStatusResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BcknddockerRegistrySecretWithSensitiveDataRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BcknddockerRegistrySecretWithSensitiveDataRequestData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndobjectStoreSecretCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndobjectStoreSecretDeletionResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndobjectStoreSecretModificationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndobjectStoreSecretStatus.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndobjectStoreSecretStatusMetadata.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndobjectStoreSecretStatusResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndobjectStoreSecretWithSensitiveDataRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/BckndobjectStoreSecretWithSensitiveDataRequestForPostCall.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/DSetError.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/DSetErrorDetailsInner.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/DSetFileCreationResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/FileDownload400Response.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/KpiApiError.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/KpiGet400Response.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/KpiResultRowItem.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/KpiResultSet.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/KubesubmitV4ApplicationsCreateRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/KubesubmitV4DockerRegistrySecretsCreateRequest.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAPIVersion.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAiApi.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAiApiCapabilities.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAiApiCapabilitiesBulkUpdates.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAiApiCapabilitiesLogs.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAiApiLimits.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAiApiLimitsDeployments.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAiApiLimitsExecutions.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaAiApiLimitsTimeToLiveDeployments.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaApiError.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaCapabilities.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaExtensions.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaExtensionsAnalytics.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaExtensionsDataset.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaExtensionsDatasetCapabilities.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaExtensionsDatasetLimits.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaExtensionsMetrics.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaExtensionsMetricsCapabilities.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetaGet404Response.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/MetricsFind400Response.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAArtifact.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAArtifactLabel.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTABackendDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTADeployment.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTADeploymentDetails.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAError.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAErrorResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAExecutable.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAExecutableArgumentBinding.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAExecutableArtifact.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAExecutableParameter.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAExecution.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAInputArtifactArgumentBinding.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTALabel.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTALogCommonData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTALogCommonResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTALogCommonResultItem.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAModelBaseData.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAModelVersion.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAOutputArtifactArgumentBinding.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/RTAScenario.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckApiError.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckCustomInfoObject.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckDeleteMetricsResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckDetailsErrorResponse.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckExecutionId.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckGetMetric.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckGetMetricResource.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckGetMetricResourceList.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckLabel.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckMetric.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckMetricResource.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckTag.java
#	core/src/main/java/com/sap/ai/sdk/core/client/model/TrckTagName.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/AzureContentSafety.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/ChatMessage.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/CompletionPostRequest.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/CompletionPostResponse.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/ErrorResponse.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/Filter.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/FilterConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/FilteringConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/FilteringModuleConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/GenericModuleResult.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/GroundingFilter.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/GroundingModuleConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/GroundingModuleConfigGroundingServiceConfiguration.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/LLMChoice.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/LLMModuleConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/LLMModuleResult.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/Masking.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/MaskingEntitiesInner.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/MaskingModuleConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/ModuleConfigs.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/ModuleResults.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/OrchestrationConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/OrchestrationV1EndpointsHealthz503Response.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/TemplatingModuleConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/TokenUsage.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/UnmaskingConfig.java
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/UnmaskingConfigEntitiesInner.java
Comment on lines 177 to 178
new String(
getClass()
.getClassLoader()
.getResourceAsStream("templatingRequest.json")
.readAllBytes());
new String(
getClass()
.getClassLoader()
.getResourceAsStream("templatingRequest.json")
.readAllBytes());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install the google-java-format plugin and reformat.
Also, should we enable spotless on generated files in this PR or in a next PR?

Copy link
Contributor Author

@newtork newtork Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran format on the test class and pom file, and committed it.

I don't understand why you want the files to be formatted when it was you who disabled the plugin in the first place.

Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated the code samples

@newtork newtork merged commit c33b608 into main Aug 14, 2024
5 checks passed
@newtork newtork deleted the openapi/with-builder branch August 14, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants