Orchestration streaming #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
reviewed
Dec 10, 2024
| * content_filter | ||
| */ | ||
| @Nonnull | ||
| public Stream<String> streamChatCompletion( |
There was a problem hiding this comment.
(Comment)
New method names match the existing OpenAiClient counter-part in openai module.
newtork
reviewed
Dec 10, 2024
| } | ||
| return IterableStreamConverter.lines(response.getEntity()) | ||
| // half of the lines are empty newlines, the last line is "data: [DONE]" | ||
| .peek(line -> log.info("Handler: {}", line)) |
There was a problem hiding this comment.
(Comment)
I'm surprised we have so many info log statements. I feel like we could define a coding guideline when to use what log level.
(no action required.)
newtork
reviewed
Dec 10, 2024
newtork
reviewed
Dec 10, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 10, 2024
newtork
reviewed
Dec 10, 2024
orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
Show resolved
Hide resolved
# Conflicts: # docs/guides/ORCHESTRATION_CHAT_COMPLETION.md
newtork
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#71.
As an orchestration user I want to stream responses, similarly to streaming when using OpenAI
Feature scope:
streamChatCompletionDeltas()andstreamChatCompletion()to theOrchestrationClientDefinition of Done
Aligned changes with the JavaScript SDK