[work in progress] Rework samples #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finkmanAtSap
approved these changes
Oct 15, 2024
finkmanAtSap
requested changes
Oct 15, 2024
kuntzed
force-pushed
the
rework_samples
branch
2 times, most recently
from
870b62a
to
16304d4
Compare
yep, the github action runners are obviously using an old version of the maven-compiler-plugin by default. this is probably a consequence of using an old maven version. maybe we should try to control the maven version, but for now I have simply increased the required plugin version in the samples' pom files. |
kuntzed
force-pushed
the
rework_samples
branch
2 times, most recently
from
ada3501
to
b76627e
Compare
- README rewritten based on the java-security-usage sample - added k8s support
- README rewritten
- added k8s support
Also: fix k8s build
kuntzed
force-pushed
the
rework_samples
branch
from
10b3da1
to
a21e6aa
Compare
finkmanAtSap
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the readability of the samples applications we do some small refactorings and bugfixes. This includes implementation and configuration harmonisations. Furthermore, additional examples for k8b are added and the instructions (README files) for the samples are rewritten.