Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored LLM Integration #388

Merged
merged 37 commits into from
Jul 4, 2024
Merged

Refactored LLM Integration #388

merged 37 commits into from
Jul 4, 2024

Conversation

lauraschauer
Copy link
Contributor

This refactors the LLM integration. The most important changes are:

  • Creates a singleton wrapper class for all llm-related functions and the instance of the model called LLMService
  • Simplifies model instantiation
  • Fixes tests

@lauraschauer
adjusts tests
df82247
@lauraschauer
basic refactoring mvp
520e67d
@lauraschauer
I can run the code, but the singleton pattern implemented with metacl…
da1d558 
…asses still doesn't work
@lauraschauer
singleton pattern works
6b2b982
@lauraschauer
move models into their own files
3efb1a6
@lauraschauer
updates tests
f306298
@lauraschauer
corrects information about missing commits to be logged as info inste…
a7cf5fd 
…ad of error
@lauraschauer
moves singleton metaclass into utils
1cb3673
@lauraschauer
adds tests
15057d8
@lauraschauer
changes variable name d to model_definition for clarity
d55735d
@lauraschauer
moves ai core sk filepath to config.yaml
0a6d1c0
@lauraschauer
adds StrOutputParser to model chain and prints returned URL to console
8d105db
@lauraschauer
streamlines error handling
92a5401
@lauraschauer
updates README with explanation of llm_service parameters in config.yaml
5601ef0 
before pushing, make sure that this information about sk.json can be pushed!
@lauraschauer
removes internal URL
95b3917
@lauraschauer
corrects mistake in singleton logger value
beab86e
@lauraschauer
adds singleton tests
a672e7d
@lauraschauer
refactors: LLMService is created in main, when there is access to the…
8e9efc5 
… config.llm_service. When LLMService is needed again, just access the instance using LLMService() without having to supply the config.
@lauraschauer
refactors: simplifies model_instantiation, gets rid of two layer inhe…
bb8701b 
…ritance (no more SAPLLM)
@lauraschauer
updates tests
291935c
@lauraschauer
adds correct strings to return from _llm_type()
1409b01
@lauraschauer
corrects docstring
1216710
@lauraschauer
renames file
72e0f30
@lauraschauer
final touch-up
8afa9c5
@lauraschauer
fixes bug where a LLMService could not be created. Check logs. error …
cc85b0b 
…was raised even though the use of llms was set to false

This happened because the LLMService singleton was initialised even though it would not be needed later on. This happened because of an error in an if statement
@lauraschauer
fixes tests
e45a136 
fixes the environment variables iin the LLM tets and fixes sometest files unrelated to LLMss
@lauraschauer
removes extra index urls
be27723
@lauraschauer
more env variables mocking for tests
5a14377
@lauraschauer
small modification to prompt
32ef6fb
@lauraschauer
removes pip options
1d215b5
@copernico copernico merged commit 2633695 into SAP:main Jul 4, 2024
3 checks passed
@lauraschauer lauraschauer deleted the lascha-llm-service branch July 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copernico copernico copernico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lauraschauer @copernico