Skip to content

Commit

Permalink
chore: address code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
akudev committed May 7, 2024
1 parent 489d599 commit 3e0226b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/dts-generator/src/js-utils/ui5-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const log = getLogger("@ui5/dts-generator/download-apijson");
* @returns {Promise<Record<string, UI5Lib>>}
*/
export async function getSAPUI5LibsMeta(version) {
const version_pattern = /^[0-9]+\.[0-9]+\.[0-9]+.*$/; // .* to cover any potential suffixes; being ready for that is more important than being 100% strict
const version_pattern = /^[0-9]+\.[0-9]+\.[0-9]+(?:[^0-9].*)?$/; // .* to cover any potential suffixes; being ready for that is more important than being 100% strict
if (!version_pattern.test(version)) {
throw new Error(
`Version is given as '${version}', but must be a full UI5 version string like '1.120.2'.`,
Expand Down

0 comments on commit 3e0226b

Please sign in to comment.