feat(ts-interface-generator): support non-default-export classes #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create appropriate interface for classes which are not default exports; this will make cases work when the default export is an *instance* of the class (but it still requires the class itself to be exported as named export, so the module augmentation can kick in). - Add new way of writing finer-grained tests, so new cases can be covered more easily - Re-initialize base types for each generation to handle multiple invocations in different type worlds properly - happens in tests - Rename the "testdata" folder to "samples"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create appropriate interface for classes which are not default exports; this will make cases work when the default export is an instance of the class (but it still requires the class itself to be exported as named export, so the module augmentation can kick in).
Add new way of writing finer-grained tests, so new cases can be covered more easily
Re-initialize base types for each generation to handle multiple invocations in different type worlds properly - happens in tests
Rename the "testdata" folder to "samples"