Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/hhausner a5818 compatability #170

Draft
wants to merge 7 commits into
base: release/v1_10_04
Choose a base branch
from
Draft

Feature/hhausner a5818 compatability #170

wants to merge 7 commits into from

Conversation

hausnerh
Copy link

Description

Add compatibility for ICARUS boardreader code to use A5818 cards

Testing details

TBD

gennadiy-fnal and others added 3 commits November 19, 2024 13:45
@gennadiy-fnal
Merge pull request #169 from SBNSoftware/release/v1_10_03
53332e7 
Release/v1 10 03
@hausnerh
Update PhysCrateData_generator.cc
24d6c8a 
Edit ReadFirmwareVersion to handle A5818 cards. Generator now looks for a "AX818" fhicl parameter, which defaults to 3. If set to 5 it looks for an A5818 card.
@hausnerh
Update A2795Board.cc
33928a3 
Removed depreciated use of CAENComm_OpenDevice
Replaced with CAENComm_OpenDevice2.
The difference is in the second argument being a pointer to the link number as opposed to the raw link number.
@gennadiy-fnal gennadiy-fnal changed the base branch from develop to release/v1_10_04 November 21, 2024 20:12
@mvicenzi
Copy link
Member

Hi @hausnerh, would you be able to add the switcheroo between cvA3818 and cvA5818 also for CAENV1730Readout::GetSWInfo()?

I believe that's the only other place where we explicitly refer to an A3818 connection (the optical link is opened using CAENDGTZ::OpenDigitizer() which should handle things internally).

@hausnerh
Update CAENConfiguration.hh to add AX818 configuration
3f20e43 
add parameter to set if we are using the A5818 cards or not
@hausnerh
Update CAENConfiguration.cc for A5818 compatibility
da950e3 
Add parameter for configuring running with A5818 cards. Default to A3818 (our standard running configuration)
@hausnerh
Update CAENConfiguration.cc
1efef31 
This is Common, not SBND specific. ICARUS also uses this configuration class.
@hausnerh
Update CAENV1730Readout_generator.cc for A5818 compatibility
89e59f9 
use configuration in fCAEN to toggle which PCIe board is being used
@hausnerh
Copy link
Author

Hi @hausnerh, would you be able to add the switcheroo between cvA3818 and cvA5818 also for CAENV1730Readout::GetSWInfo()?

I believe that's the only other place where we explicitly refer to an A3818 connection (the optical link is opened using CAENDGTZ::OpenDigitizer() which should handle things internally).

Added

dtorretta56
dtorretta56 approved these changes Nov 22, 2024
View reviewed changes
Copy link

@dtorretta56 dtorretta56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to me.
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtorretta56 dtorretta56 dtorretta56 approved these changes

@mvicenzi mvicenzi Awaiting requested review from mvicenzi

Assignees

@hausnerh hausnerh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hausnerh @mvicenzi @dtorretta56 @gennadiy-fnal