Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use system Podman package #11

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

pedorich-n
Copy link
Contributor

Use case: I tun stable NixOS, but I use podman from the unstable channel. The current config results in two versions of podman used: quadlets are generated with 5.2.3 (from stable), but containers are running in 5.3.0 (from unstable)

home-manager-module.nix Outdated Show resolved Hide resolved
nixos-module.nix Outdated Show resolved Hide resolved
home-manager-module.nix Outdated Show resolved Hide resolved
network.nix Outdated Show resolved Hide resolved
@pedorich-n pedorich-n changed the title feat: expose podman package option feat: use system Podman package Dec 5, 2024
Copy link
Owner

@SEIAROTg SEIAROTg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor changes. Thanks!

utils.nix Outdated Show resolved Hide resolved
home-manager-module.nix Outdated Show resolved Hide resolved
@pedorich-n
Copy link
Contributor Author

@SEIAROTg something like this?

@SEIAROTg SEIAROTg merged commit 6a09501 into SEIAROTg:main Dec 6, 2024
2 checks passed
@pedorich-n pedorich-n deleted the fix-package branch December 6, 2024 10:20
@pedorich-n
Copy link
Contributor Author

Also, @SEIAROTg FYI: I think using config.virtualisation.podman.package might eliminate the need for /run/wrappers/bin in PATH, as it's already included in the default podman package: https://github.com/NixOS/nixpkgs/blob/102ad463591c127667467d1244f45223043e96e3/nixos/modules/virtualisation/podman/default.nix#L11.
But maybe it's worth leaving, just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants