feat: Adds UIDMap and GIDMap to containerConfig #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GIDMap allows for more advanced group configurations than userNS can do. Useful for solving permission issues with containers that arent built to run with rootless operation in mind.
Adds UIDMap option to quadlet-nix. Allows for more advanced UID configurations. Useful for solving permission issues with containers that arent designed to function rootless.
SEIAROTg
reviewed
Dec 10, 2024
container.nix
Outdated
| @@ -142,6 +142,14 @@ let | |||
| description = "--user UID:..."; | |||
| property = "Group"; | |||
| }; | |||
|
|
|||
| gidMap = quadletUtils.mkOption { | |||
| type = types.nullOr types.str; | |||
There was a problem hiding this comment.
This key can be listed multiple times.
https://docs.podman.io/en/latest/markdown/podman-systemd.unit.5.html#gidmap.
Let's make it a list and have a plural name.
There was a problem hiding this comment.
Made the suggested changes. Their now lists and have plural names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UIDMap and GIDMap options to map ownership of the host user to the container user.
Although most situations are already covered by userNS and its many modes. There are situations where userNS doesnt cut it and can cause ownership/permission issues with volumes and mounts. This is especially prevalent in containers that use things like s6-overay which arent built to run under a rootless user. The process looses permissions if its set to anything else than UID/GID=0 which renders the container useless.
PS: also this merge request fixes a tiny typo in the flake.nix rootless example.