feat: Add AddHost; Improve types #9
Conversation
| default = [ ]; | ||
| example = ["hostname:192.168.10.11"]; | ||
| description = "--add-host"; | ||
| property = "AddHost"; |
There was a problem hiding this comment.
Support for AddHost was added in containers/podman#23713
It's available since Podman v5.3.1. The current version in the 24.11 channel is 5.2.3. This makes me wonder if it's worth adding a warning if the version is less than 5.3.1.
But this creates a maintaining burden, to keep track of all the podman versions... 🤔
There was a problem hiding this comment.
LGTM given the default value is safe.
There are too many ways the config could be bad and surely we can't catch all. Thus I don't see this project should be responsible for config check beyond what's trivial to do.
| @@ -87,7 +95,7 @@ let | |||
| }; | |||
|
|
|||
| environments = quadletUtils.mkOption { | |||
| type = types.attrs; | |||
| type = types.attrsOf types.str; | |||
There was a problem hiding this comment.
This might break existing configuration for some users, but IMO it's worth enforcing the str, since toString is unreliable. For example toString with boolean produces "" for false and "1" for true. 🤯
| @@ -87,7 +95,7 @@ let | |||
| }; | |||
|
|
|||
| environments = quadletUtils.mkOption { | |||
| type = types.attrs; | |||
| type = types.attrsOf types.str; | |||
| default = [ ]; | ||
| example = ["hostname:192.168.10.11"]; | ||
| description = "--add-host"; | ||
| property = "AddHost"; |
There was a problem hiding this comment.
LGTM given the default value is safe.
There are too many ways the config could be bad and surely we can't catch all. Thus I don't see this project should be responsible for config check beyond what's trivial to do.
No description provided.